morningman commented on a change in pull request #8035:
URL: https://github.com/apache/incubator-doris/pull/8035#discussion_r806896577
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/http/rest/BootstrapFinishAction.java
##########
@@ -37,6 +37,7 @@
* {"status":"OK","msg":"Success","replayedJournal"=123456, "queryPort"=9000,
"rpcPort"=9001}
* {"status":"FAILED","msg":"err info..."}
*/
+@Deprecated
Review comment:
Why deprecate this?
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/http/rest/BootstrapFinishAction.java
##########
@@ -37,6 +37,7 @@
* {"status":"OK","msg":"Success","replayedJournal"=123456, "queryPort"=9000,
"rpcPort"=9001}
* {"status":"FAILED","msg":"err info..."}
*/
+@Deprecated
Review comment:
I thought that `BootstrapFinishAction` is nothing to do with the
heartbeat?
It is used for checking whether the FE is started successfully.
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/http/rest/BootstrapFinishAction.java
##########
@@ -37,6 +37,7 @@
* {"status":"OK","msg":"Success","replayedJournal"=123456, "queryPort"=9000,
"rpcPort"=9001}
* {"status":"FAILED","msg":"err info..."}
*/
+@Deprecated
Review comment:
Oh, I forgot. But this API is also used for checking whether FE is
started.
So we still need it. Just not use it for heartbeat.
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/http/rest/BootstrapFinishAction.java
##########
@@ -37,6 +37,7 @@
* {"status":"OK","msg":"Success","replayedJournal"=123456, "queryPort"=9000,
"rpcPort"=9001}
* {"status":"FAILED","msg":"err info..."}
*/
+@Deprecated
Review comment:
And by the way, most of user does not switch the heartbeat method to
thrift way. So maybe we need notice the user by somehow.
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/http/rest/BootstrapFinishAction.java
##########
@@ -37,6 +37,7 @@
* {"status":"OK","msg":"Success","replayedJournal"=123456, "queryPort"=9000,
"rpcPort"=9001}
* {"status":"FAILED","msg":"err info..."}
*/
+@Deprecated
Review comment:
And by the way, most of user does not switch the heartbeat method to
thrift way. So maybe we need notice the user by somehow. And you forgot the
complete the required fields in PR template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
