xiaokang commented on code in PR #34089:
URL: https://github.com/apache/doris/pull/34089#discussion_r1634146854
##########
be/src/vec/jsonb/serialize.cpp:
##########
@@ -55,12 +57,15 @@ void JsonbSerializeUtil::block_to_jsonb(const TabletSchema&
schema, const Block&
for (int j = 0; j < num_cols; ++j) {
const auto& column = block.get_by_position(j).column;
const auto& tablet_column = *schema.columns()[j];
+ // ignore row store columns
if (tablet_column.is_row_store_column()) {
- // ignore dst row store column
continue;
}
- serdes[j]->write_one_cell_to_jsonb(*column, jsonb_writer, &pool,
- tablet_column.unique_id(), i);
+ // TODO improve performance for checking column in group
Review Comment:
preprocess a vector<bool>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
