This is an automated email from the ASF dual-hosted git repository.
zhangchen pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new 02d0ef80080 [branch-2.0](cherry-pick) update some CHECK to CHECK_EQ,
to print more details while CHECK failed (#33709) (#36323)
02d0ef80080 is described below
commit 02d0ef80080432085f839301705a19e0416f9d94
Author: zhannngchen <[email protected]>
AuthorDate: Fri Jun 14 21:38:00 2024 +0800
[branch-2.0](cherry-pick) update some CHECK to CHECK_EQ, to print more
details while CHECK failed (#33709) (#36323)
cherry-pick #33709
---
be/src/olap/rowset/segment_v2/segment_writer.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/be/src/olap/rowset/segment_v2/segment_writer.cpp
b/be/src/olap/rowset/segment_v2/segment_writer.cpp
index 2f3fb67ae62..c9fc6a939cb 100644
--- a/be/src/olap/rowset/segment_v2/segment_writer.cpp
+++ b/be/src/olap/rowset/segment_v2/segment_writer.cpp
@@ -510,7 +510,7 @@ Status
SegmentWriter::append_block_with_partial_content(const vectorized::Block*
{loc.rowset_id, loc.segment_id,
DeleteBitmap::TEMP_VERSION_COMMON}, loc.row_id);
}
}
- CHECK(use_default_or_null_flag.size() == num_rows);
+ CHECK_EQ(use_default_or_null_flag.size(), num_rows);
if (config::enable_merge_on_write_correctness_check) {
_tablet->add_sentinel_mark_to_delete_bitmap(_mow_context->delete_bitmap.get(),
@@ -582,7 +582,7 @@ Status
SegmentWriter::fill_missing_columns(vectorized::MutableColumns& mutable_f
// create old value columns
const auto& cids_missing =
_opts.rowset_ctx->partial_update_info->missing_cids;
auto old_value_block = _tablet_schema->create_block_by_cids(cids_missing);
- CHECK(cids_missing.size() == old_value_block.columns());
+ CHECK_EQ(cids_missing.size(), old_value_block.columns());
auto mutable_old_columns = old_value_block.mutate_columns();
bool has_row_column = _tablet_schema->store_row_column();
// record real pos, key is input line num, value is old_block line num
@@ -1073,7 +1073,7 @@ Status SegmentWriter::_write_short_key_index() {
}
Status SegmentWriter::_write_primary_key_index() {
- CHECK(_primary_key_index_builder->num_rows() == _row_count);
+ CHECK_EQ(_primary_key_index_builder->num_rows(), _row_count);
return
_primary_key_index_builder->finalize(_footer.mutable_primary_key_index_meta());
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
