This is an automated email from the ASF dual-hosted git repository.

dataroaring pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-2.0 by this push:
     new f8405e7fc69 [fix](parquet) Fix possible memory leak if 
ParquetReader::parse_thrift_footer failed (#31375) (#36216)
f8405e7fc69 is described below

commit f8405e7fc69756f808acbeb93ab069b757c22418
Author: Gavin Chou <[email protected]>
AuthorDate: Fri Jun 14 21:30:47 2024 +0800

    [fix](parquet) Fix possible memory leak if 
ParquetReader::parse_thrift_footer failed (#31375) (#36216)
    
    Pick from doris master #31375
---
 be/src/vec/exec/format/parquet/vparquet_reader.cpp | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/be/src/vec/exec/format/parquet/vparquet_reader.cpp 
b/be/src/vec/exec/format/parquet/vparquet_reader.cpp
index a57004e6608..e0bd043c713 100644
--- a/be/src/vec/exec/format/parquet/vparquet_reader.cpp
+++ b/be/src/vec/exec/format/parquet/vparquet_reader.cpp
@@ -235,11 +235,10 @@ Status ParquetReader::_open_file() {
         }
         size_t meta_size = 0;
         if (_meta_cache == nullptr) {
-            RETURN_IF_ERROR(
-                    parse_thrift_footer(_file_reader, &_file_metadata, 
&meta_size, _io_ctx));
+            auto st = parse_thrift_footer(_file_reader, &_file_metadata, 
&meta_size, _io_ctx);
             // wrap it with unique ptr, so that it can be released finally.
             _file_metadata_ptr.reset(_file_metadata);
-            _file_metadata = _file_metadata_ptr.get();
+            RETURN_IF_ERROR(st);
 
             _column_statistics.read_bytes += meta_size;
             // parse magic number & parse meta data


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to