xinyiZzz commented on a change in pull request #8322:
URL: https://github.com/apache/incubator-doris/pull/8322#discussion_r824318245
##########
File path: be/src/runtime/disk_io_mgr.h
##########
@@ -691,8 +695,9 @@ class DiskIoMgr {
// Pool to allocate BufferDescriptors.
ObjectPool _pool;
- // Process memory tracker; needed to account for io buffers.
- std::shared_ptr<MemTracker> _process_mem_tracker;
+ std::shared_ptr<MemTracker> _mem_tracker;
+ // account for io buffers.
+ std::shared_ptr<MemTracker> _cached_buffers_mem_tracker;
Review comment:
No difference now, I removed it to avoid ambiguity
It will be used when automatically recording memory through Hook new/delete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
