xinyiZzz commented on a change in pull request #8322:
URL: https://github.com/apache/incubator-doris/pull/8322#discussion_r824321241
##########
File path: be/src/runtime/mem_pool.cpp
##########
@@ -115,20 +131,10 @@ bool MemPool::find_chunk(size_t min_size, bool
check_limits) {
}
chunk_size = BitUtil::RoundUpToPowerOfTwo(chunk_size);
- if (check_limits) {
Review comment:
check_limit = false, which means that the memory limit is not checked
when calling MemTracker::consume.
In fact, most MemPools in Doris currently use check_limit = false when
applying for memory. Hereafter, when refactoring MemPool, it can be sorted out
uniformly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
