github-actions[bot] commented on code in PR #38549:
URL: https://github.com/apache/doris/pull/38549#discussion_r1699993560
##########
be/src/util/block_compression.cpp:
##########
@@ -738,6 +752,32 @@ class SnappyBlockCompression : public
BlockCompressionCodec {
size_t max_compressed_len(size_t len) override { return
snappy::MaxCompressedLength(len); }
};
+class HadoopSnappyBlockCompression : public SnappyBlockCompression {
+public:
+ static HadoopSnappyBlockCompression* instance() {
+ static HadoopSnappyBlockCompression s_instance;
+ return &s_instance;
+ }
+ ~HadoopSnappyBlockCompression() override {}
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
~HadoopSnappyBlockCompression() override = default;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
