github-actions[bot] commented on code in PR #38549:
URL: https://github.com/apache/doris/pull/38549#discussion_r1700395890
##########
be/src/util/block_compression.cpp:
##########
@@ -816,6 +857,75 @@ class ZlibBlockCompression : public BlockCompressionCodec {
}
};
+class Bzip2BlockCompression : public BlockCompressionCodec {
+public:
+ static Bzip2BlockCompression* instance() {
+ static Bzip2BlockCompression s_instance;
+ return &s_instance;
+ }
+ ~Bzip2BlockCompression() {}
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
~Bzip2BlockCompression() = default;
```
##########
be/src/util/block_compression.cpp:
##########
@@ -816,6 +857,75 @@
}
};
+class Bzip2BlockCompression : public BlockCompressionCodec {
+public:
+ static Bzip2BlockCompression* instance() {
+ static Bzip2BlockCompression s_instance;
+ return &s_instance;
+ }
+ ~Bzip2BlockCompression() {}
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
```suggestion
~Bzip2BlockCompression() override {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
