wangshuo128 commented on a change in pull request #8618:
URL: https://github.com/apache/incubator-doris/pull/8618#discussion_r833914316
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/PlanNode.java
##########
@@ -870,4 +864,22 @@ public void convertToVectoriezd() {
child.convertToVectoriezd();
}
}
+
+ // The slotIdSet could be null
+ public void initOutputSlotIds(Set<SlotId> slotIdSet, Analyzer analyzer)
throws NotImplementedException {
Review comment:
I think `slotIdSet` is a bit generic, what about `requiredSlotIds` ?
```suggestion
public void initOutputSlotIds(Set<SlotId> requiredSlotIds, Analyzer
analyzer) throws NotImplementedException {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
