englefly commented on a change in pull request #8618:
URL: https://github.com/apache/incubator-doris/pull/8618#discussion_r836540483



##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/HashJoinNode.java
##########
@@ -165,6 +170,54 @@ public void setColocate(boolean colocate, String reason) {
         colocateReason = reason;
     }
 
+    // output slots + conjunct slots + other conjunct slots = hash output slots

Review comment:
       What is the difference between "output slots" and "hash output slots"?
   What is the usage of the concept "hash output slots"?
   Could u illustrate the above questions by the example in comments (line 882) 
   * Query: select a.k1 from a, b where a.k1=b.k1
   * output slots: a.k1
   in my understanding, the conjunct is a.k1=b.k1, and a.k1/b.k1 is not in 
output slots, but in hash output slots.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to