liaoxin01 commented on code in PR #38003:
URL: https://github.com/apache/doris/pull/38003#discussion_r1704003345
##########
be/src/vec/sink/writer/vtablet_writer_v2.cpp:
##########
@@ -568,23 +594,39 @@ Status VTabletWriterV2::close(Status exec_status) {
// send CLOSE_LOAD on all non-incremental streams if this is the last
sink
if (is_last_sink) {
- RETURN_IF_ERROR(_load_stream_map->close_load(false));
+ auto st = _load_stream_map->close_load(false);
+ if (!st.ok()) {
+ LOG(WARNING) << "close_load failed: " << st;
+ }
}
// close_wait on all non-incremental streams, even if this is not the
last sink.
// because some per-instance data structures are now shared among all
sinks
// due to sharing delta writers and load stream stubs.
- RETURN_IF_ERROR(_close_wait(false));
+ {
+ auto st = _close_wait(false);
+ if (!st.ok()) {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
