kaijchen commented on code in PR #38003:
URL: https://github.com/apache/doris/pull/38003#discussion_r1705275717
##########
be/src/vec/sink/writer/vtablet_writer_v2.cpp:
##########
@@ -651,9 +694,12 @@ Status VTabletWriterV2::_close_wait(bool incremental) {
<< print_id(_load_id);
return Status::TimedOut("load timed out before close
waiting");
}
- RETURN_IF_ERROR(stream->close_wait(_state, remain_ms));
+ auto st = stream->close_wait(_state, remain_ms);
+ if (!st.ok() && status.ok()) {
+ status = st;
+ }
}
- return Status::OK();
+ return status;
Review Comment:
This is inside lambda, see `LoadStreamMap::for_each_st()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]