yiguolei commented on a change in pull request #7529:
URL: https://github.com/apache/incubator-doris/pull/7529#discussion_r835766984
##########
File path: be/src/olap/rowset/beta_rowset.h
##########
@@ -53,9 +53,10 @@ class BetaRowset : public Rowset {
OLAPStatus link_files_to(const FilePathDesc& dir_desc, RowsetId
new_rowset_id) override;
- OLAPStatus copy_files_to(const std::string& dir) override;
+ OLAPStatus copy_files_to(const std::string& dir, RowsetId new_rowset_id)
override;
- OLAPStatus upload_files_to(const FilePathDesc& dir_desc) override;
+ OLAPStatus upload_files_to(const FilePathDesc& dir_desc,
Review comment:
why need this api?
##########
File path: be/src/olap/rowset/alpha_rowset.cpp
##########
@@ -110,7 +110,7 @@ OLAPStatus AlphaRowset::link_files_to(const FilePathDesc&
dir_desc, RowsetId new
return OLAP_SUCCESS;
Review comment:
not support alpha rowset any more, just return error and stop migration
job if this rowset is alpharowset
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
