yiguolei commented on a change in pull request #7529:
URL: https://github.com/apache/incubator-doris/pull/7529#discussion_r835832329



##########
File path: be/src/olap/base_tablet.cpp
##########
@@ -28,9 +29,10 @@ extern MetricPrototype METRIC_query_scan_bytes;
 extern MetricPrototype METRIC_query_scan_rows;
 extern MetricPrototype METRIC_query_scan_count;
 
-BaseTablet::BaseTablet(TabletMetaSharedPtr tablet_meta, DataDir* data_dir)
+BaseTablet::BaseTablet(TabletMetaSharedPtr tablet_meta, const StorageParamPB& 
storage_param, DataDir* data_dir)

Review comment:
       Not add a new parameter, StorageParam should be part of TabletMeta




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to