yiguolei edited a comment on pull request #7529: URL: https://github.com/apache/incubator-doris/pull/7529#issuecomment-1079815584
I have reviewed the code, it is too complicated, It should be simplified. 1. I find that you reused the schema change logic. It's ok to reuse the logic but not reuse the code, we should not modify schema change code since it is very serious. We should rewrite a new job very like schema change. Because some logic has micro differences, for example there are 10 tablet doing migration, if one tablet failed, then schema change is failed, but storage migration should ignore the failure and may add a new task for the failed tablet. 2. I think if user set the partition to COLD, then it should be freezed, not allow to insert new data. It is acceptable. But I think It is very important to allow SCHEMA CHANGE!!! because schema change is table level. 3. If the tablet is a new tablet and it is not writeable, or do compaction, then there should be no rubbish or garbage, so that we do not need to care about gc or sweep logic for remote storage. 4. FE should care about rubbish tablet for example if one tablet do migration failed fe should do gc logic. For example, FE may call BE's API do this gc logic. 5. Remote Storage Medium is set to tablet level, it is ok. But not a separate parameter, it should be part of table meta both in FE and BE. 6. We should write clone logic on FE maybe it is just a create tablet logic on BE, BE just load the header file from remote storage. 7. There are also many other logics like backup, restore, snapshot logic. Maybe we could disable some feature at current step and implement them in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
