yiguolei edited a comment on pull request #7529:
URL: https://github.com/apache/incubator-doris/pull/7529#issuecomment-1079818538
Some method in Env is useless, for example `new_sequential_file` it is only
used in
`
Status get_thread_stats(int64_t tid, ThreadStats* stats) {
DCHECK(stats != nullptr);
if (kTicksPerSec <= 0) {
return Status::NotSupported("ThreadStats not supported");
}
faststring buf;
RETURN_IF_ERROR(env_util::read_file_to_string(
Env::Default(), strings::Substitute("/proc/self/task/$0/stat",
tid), &buf));
return parse_stat(buf.ToString(), nullptr, stats);
}
`
It does not make sense to be part of Env. What about just use posix api do
to this and simplify Env Interface.
new_random_access_file is used in read cluster id. It is not related with
remote storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
