yiguolei commented on a change in pull request #8680:
URL: https://github.com/apache/incubator-doris/pull/8680#discussion_r836043938
##########
File path: be/src/olap/rowset/segment_v2/bitmap_index_reader.h
##########
@@ -50,13 +50,13 @@ class BitmapIndexReader {
int64_t bitmap_nums() { return _bitmap_column_reader->num_values(); }
- std::shared_ptr<const TypeInfo> type_info() { return _typeinfo; }
+ const TypeInfo* type_info() { return _typeinfo; }
private:
friend class BitmapIndexIterator;
FilePathDesc _path_desc;
- std::shared_ptr<const TypeInfo> _typeinfo;
+ const TypeInfo* _typeinfo;
Review comment:
Use reference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
