zbtzbtzbt commented on a change in pull request #8680:
URL: https://github.com/apache/incubator-doris/pull/8680#discussion_r836041833
##########
File path: be/src/olap/rowset/segment_v2/indexed_column_reader.cpp
##########
@@ -31,12 +31,12 @@ Status IndexedColumnReader::load(bool use_page_cache, bool
kept_in_memory) {
_use_page_cache = use_page_cache;
_kept_in_memory = kept_in_memory;
- _type_info = get_type_info((FieldType)_meta.data_type());
+ _type_info = get_scalar_type_info((FieldType)_meta.data_type());
Review comment:
question: can we make sure that the type here is scalar type?
##########
File path: be/src/olap/tablet_schema.cpp
##########
@@ -286,7 +286,7 @@ TabletColumn::TabletColumn(FieldAggregationMethod agg,
FieldType type) {
TabletColumn::TabletColumn(FieldAggregationMethod agg, FieldType filed_type,
bool is_nullable) {
_aggregation = agg;
_type = filed_type;
- _length = get_type_info(filed_type)->size();
+ _length = get_scalar_type_info(filed_type)->size();
Review comment:
question: can we make sure that the type here is scalar type?
##########
File path: be/src/olap/column_vector.h
##########
@@ -150,7 +150,7 @@ class ScalarColumnVectorBatch : public ColumnVectorBatch {
class ArrayNullColumnVectorBatch : public ColumnVectorBatch {
public:
explicit ArrayNullColumnVectorBatch(ColumnVectorBatch* array)
- :
ColumnVectorBatch(get_scalar_type_info(FieldType::OLAP_FIELD_TYPE_TINYINT),
false),
+ :
ColumnVectorBatch(get_scalar_type_info<FieldType::OLAP_FIELD_TYPE_TINYINT>(),
false),
Review comment:
we can also delete prefix`FieldType::` here, and other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
