JNSimba commented on code in PR #465:
URL:
https://github.com/apache/doris-flink-connector/pull/465#discussion_r1710968290
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/table/DorisConfigOptions.java:
##########
@@ -307,7 +307,16 @@ public class DorisConfigOptions {
.booleanType()
.defaultValue(false)
.withDescription("Whether to use buffer cache for
breakpoint resume");
-
+ public static final ConfigOption<Boolean> USE_FLIGHT_SQL =
+ ConfigOptions.key("use_flight_sql")
+ .booleanType()
+ .defaultValue(Boolean.FALSE)
+ .withDescription("USE_FLIGHT_SQL");
+ public static final ConfigOption<String> FLIGHT_SQL_PORT =
+ ConfigOptions.key("flight_sql_port")
+ .stringType()
+ .defaultValue("9040")
+ .withDescription("FLIGHT_SQL_PORT");
Review Comment:
The style of configuration items can be unified, such as
source.use-flight-sql
source.flight-sql-port
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
