DongLiang-0 commented on code in PR #465:
URL:
https://github.com/apache/doris-flink-connector/pull/465#discussion_r1713125161
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/rest/RestService.java:
##########
@@ -234,6 +234,38 @@ public static String parseResponse(HttpURLConnection
connection, Logger logger)
}
}
+ @VisibleForTesting
+ public static String parseFlightSql(
+ DorisReadOptions readOptions,
+ DorisOptions options,
+ PartitionDefinition partition,
+ Logger logger)
+ throws IllegalArgumentException {
+ String[] tableIdentifiers =
parseIdentifier(options.getTableIdentifier(), logger);
+ String readFields =
+ StringUtils.isBlank(readOptions.getReadFields())
+ ? "*"
+ : readOptions.getReadFields();
+ String sql =
+ "select "
+ + readFields
+ + " from `"
+ + tableIdentifiers[0]
+ + "`.`"
+ + tableIdentifiers[1]
+ + "`";
+ String tablet =
+ partition.getTabletIds().stream()
+ .map(Object::toString)
+ .collect(Collectors.joining(","));
+ sql += " TABLET(" + tablet + ") ";
Review Comment:
Why does the tablet need to be spliced in here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
