englefly commented on a change in pull request #8695:
URL: https://github.com/apache/incubator-doris/pull/8695#discussion_r837314863
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/planner/JoinCostEvaluation.java
##########
@@ -147,7 +149,7 @@ public long constructHashTableSpace() {
Math.pow(1.5, (int) ((Math.log((double)
rhsTreeCardinality/4096) / Math.log(1.5)) + 1)) * 4096;
double nodeOverheadSpace = nodeArrayLen * 16;
double nodeTuplePointerSpace = nodeArrayLen * rhsTreeTupleIdNum * 8;
- return Math.round((bucketPointerSpace + (double) rhsTreeCardinality *
rhsTreeAvgRowSize
+ return Math.round((bucketPointerSpace + (double) rhsTreeCardinality *
rhsTreeAvgRowSize * COMPRESSION_RATIO
Review comment:
> q9, q12 and q21 failed on previous cost formula.
The above 3 queries cause BE crash because of RPC exception, not hash table
size. So do we have to consider the RPC timeout? In fact, the memory is enough
in our test environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
