morrySnow commented on a change in pull request #8695:
URL: https://github.com/apache/incubator-doris/pull/8695#discussion_r838543889
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/planner/JoinCostEvaluation.java
##########
@@ -147,7 +149,7 @@ public long constructHashTableSpace() {
Math.pow(1.5, (int) ((Math.log((double)
rhsTreeCardinality/4096) / Math.log(1.5)) + 1)) * 4096;
double nodeOverheadSpace = nodeArrayLen * 16;
double nodeTuplePointerSpace = nodeArrayLen * rhsTreeTupleIdNum * 8;
- return Math.round((bucketPointerSpace + (double) rhsTreeCardinality *
rhsTreeAvgRowSize
+ return Math.round((bucketPointerSpace + (double) rhsTreeCardinality *
rhsTreeAvgRowSize * COMPRESSION_RATIO
Review comment:
> One more thing I need to remind. The current OOM has a situation as
following:
>
> There are multiple hash join nodes in one Plan Fragment. The memory of
each single hash join node is not exceeded. But the memory of the total plan
fragment is overrun. I'm not sure if this is the case in your test. If there
is, then it's not really a matter of join memory evaluation. Rather, we cannot
simply evaluate the memory problems of plan fragments.
yes, take account continuous join memory together is next step i want to do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
