adonis0147 commented on pull request #8680: URL: https://github.com/apache/incubator-doris/pull/8680#issuecomment-1082571465
Hi @caiconghui , I read the #8500 before and knew the motivation behind this pr, but the challenge is that some functions (such as `get_type_info(const TabletColumn* col)`) and some members in classes (such as `type_info` in `ColumnVectorBatch`) are used for both scalar types and dynamic types. If we manage the resource created by dynamic types and ignore the static resource for static types, the unified `const TypeInfo*` returned by some functions is appropriate. I think some functions and some usage for `TypeInfo` should be **SEPARATED** first before apply the optimization for static types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
