xinyiZzz commented on a change in pull request #8695:
URL: https://github.com/apache/incubator-doris/pull/8695#discussion_r838744590



##########
File path: 
fe/fe-core/src/main/java/org/apache/doris/planner/JoinCostEvaluation.java
##########
@@ -147,7 +149,7 @@ public long constructHashTableSpace() {
                 Math.pow(1.5, (int) ((Math.log((double) 
rhsTreeCardinality/4096) / Math.log(1.5)) + 1)) * 4096;
         double nodeOverheadSpace = nodeArrayLen * 16;
         double nodeTuplePointerSpace = nodeArrayLen * rhsTreeTupleIdNum * 8;
-        return Math.round((bucketPointerSpace + (double) rhsTreeCardinality * 
rhsTreeAvgRowSize
+        return Math.round((bucketPointerSpace + (double) rhsTreeCardinality * 
rhsTreeAvgRowSize * COMPRESSION_RATIO

Review comment:
       > yes, take account continuous join memory together is next step i want 
to do
   
   If you plan to do this later, we can discuss it~ @morrySnow 
   I am also thinking about how to estimate the memory consumption of Fragment 
and take admission control during query planning.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to