yangzhg commented on code in PR #9123:
URL: https://github.com/apache/incubator-doris/pull/9123#discussion_r855703713
##########
be/src/olap/rowset/segment_v2/binary_plain_page.h:
##########
@@ -47,14 +47,13 @@ namespace segment_v2 {
class BinaryPlainPageBuilder : public PageBuilder {
public:
BinaryPlainPageBuilder(const PageBuilderOptions& options)
- : _size_estimate(0), _prepared_size(0), _options(options) {
+ : _size_estimate(0), _options(options) {
reset();
}
bool is_page_full() override {
// data_page_size is 0, do not limit the page size
- return _options.data_page_size != 0 && (_size_estimate >
_options.data_page_size ||
- _prepared_size >
_options.data_page_size);
+ return _options.data_page_size != 0 && (_size_estimate >
_options.data_page_size);
Review Comment:
why ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
