yangzhg commented on code in PR #9123:
URL: https://github.com/apache/incubator-doris/pull/9123#discussion_r855706646
##########
be/src/olap/rowset/segment_v2/binary_dict_page.cpp:
##########
@@ -90,13 +92,18 @@ Status BinaryDictPageBuilder::add(const uint8_t* vals,
size_t* count) {
dict_item.relocate(item_mem);
}
value_code = _dictionary.size();
+ size_t add_count = 1;
+ RETURN_IF_ERROR(_dict_builder->add(reinterpret_cast<const
uint8_t*>(&dict_item),
+ &add_count));
+ if (add_count == 0) {
+ // current dict page is full, stop processing remaining
inputs
+ break;
+ }
_dictionary.emplace(dict_item, value_code);
- _dict_items.push_back(dict_item);
- _dict_builder->update_prepared_size(dict_item.size);
}
size_t add_count = 1;
- RETURN_IF_ERROR(_data_page_builder->add(reinterpret_cast<const
uint8_t*>(&value_code),
- &add_count));
+ RETURN_IF_ERROR(actual_builder->single_add(
Review Comment:
The reason for adding add internal is that I want to unify the logic of add
and single add, and I don't want to add a separate function, so add internal
doesn't want to be exposed for use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
