github-actions[bot] commented on code in PR #41782:
URL: https://github.com/apache/doris/pull/41782#discussion_r1801611087


##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -2188,4 +2188,93 @@ std::pair<MetaServiceCode, std::string> 
MetaServiceImpl::get_instance_info(
     return {code, std::move(msg)};
 }
 
+void MetaServiceImpl::fix_tablet_stats(::google::protobuf::RpcController* 
controller,

Review Comment:
   warning: function 'fix_tablet_stats' exceeds recommended size/complexity 
thresholds [readability-function-size]
   ```cpp
   void MetaServiceImpl::fix_tablet_stats(::google::protobuf::RpcController* 
controller,
                         ^
   ```
   <details>
   <summary>Additional context</summary>
   
   **cloud/src/meta-service/meta_service.cpp:2190:** 84 lines including 
whitespace and comments (threshold 80)
   ```cpp
   void MetaServiceImpl::fix_tablet_stats(::google::protobuf::RpcController* 
controller,
                         ^
   ```
   
   </details>
   



##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -2188,4 +2188,94 @@ std::pair<MetaServiceCode, std::string> 
MetaServiceImpl::get_instance_info(
     return {code, std::move(msg)};
 }
 
+void MetaServiceImpl::fix_tablet_stats(::google::protobuf::RpcController* 
controller,

Review Comment:
   warning: function 'fix_tablet_stats' exceeds recommended size/complexity 
thresholds [readability-function-size]
   ```cpp
   void MetaServiceImpl::fix_tablet_stats(::google::protobuf::RpcController* 
controller,
                         ^
   ```
   <details>
   <summary>Additional context</summary>
   
   **cloud/src/meta-service/meta_service.cpp:2190:** 85 lines including 
whitespace and comments (threshold 80)
   ```cpp
   void MetaServiceImpl::fix_tablet_stats(::google::protobuf::RpcController* 
controller,
                         ^
   ```
   
   </details>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to