github-actions[bot] commented on code in PR #42004:
URL: https://github.com/apache/doris/pull/42004#discussion_r1805163686
##########
be/src/vec/exec/format/orc/vorc_reader.cpp:
##########
@@ -109,11 +110,13 @@ static constexpr char
EMPTY_STRING_FOR_OVERFLOW[ColumnString::MAX_STRINGS_OVERFL
M(TypeIndex::Float64, Float64, orc::DoubleVectorBatch)
void ORCFileInputStream::read(void* buf, uint64_t length, uint64_t offset) {
+ read_impl(reinterpret_cast<char*>(buf), length, offset);
+}
+void ORCFileInputStream::read_impl(char* out, uint64_t length, uint64_t
offset) {
Review Comment:
warning: method 'read_impl' can be made const
[readability-make-member-function-const]
```suggestion
void ORCFileInputStream::read_impl(char* out, uint64_t length, uint64_t
offset) const {
```
be/src/vec/exec/format/orc/vorc_reader.h:662:
```diff
- ;
+ const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
