kaka11chen commented on code in PR #42004:
URL: https://github.com/apache/doris/pull/42004#discussion_r1808725645
##########
be/src/io/fs/buffered_reader.cpp:
##########
@@ -869,5 +869,106 @@ Result<io::FileReaderSPtr>
DelegateReader::create_file_reader(
return reader;
});
}
+
+Status LinearProbeRangeFinder::get_range_for(int64_t desiredOffset,
Review Comment:
desired_offset
##########
be/src/io/fs/buffered_reader.h:
##########
@@ -53,6 +53,121 @@ struct PrefetchRange {
: start_offset(start_offset), end_offset(end_offset) {}
PrefetchRange() : start_offset(0), end_offset(0) {}
+
+ PrefetchRange span(const PrefetchRange& other) const {
+ return {std::min(start_offset, other.end_offset),
std::max(start_offset, other.end_offset)};
+ }
+ PrefetchRange seq_span(const PrefetchRange& other) const {
+ return {start_offset, other.end_offset};
+ }
+
+ //Ranges needs to be sorted.
+ static std::vector<PrefetchRange> mergeAdjacentSeqRanges(
+ const std::vector<PrefetchRange>& seq_ranges, int64_t
max_merge_distance_bytes,
+ int64_t max_read_size_bytes) {
+ if (seq_ranges.empty()) {
+ return {};
+ }
+ // Merge overlapping ranges
+ std::vector<PrefetchRange> result;
+ PrefetchRange last = seq_ranges.front();
+ for (size_t i = 1; i < seq_ranges.size(); ++i) {
+ PrefetchRange current = seq_ranges[i];
+ PrefetchRange merged = last.seq_span(current);
+ if (merged.end_offset <= max_read_size_bytes + merged.start_offset
&&
+ last.end_offset + max_merge_distance_bytes >=
current.start_offset) {
+ last = merged;
+ } else {
+ result.push_back(last);
+ last = current;
+ }
+ }
+ result.push_back(last);
+ return result;
+ }
+};
+
+class RangeFinder {
+public:
+ virtual ~RangeFinder() = default;
+ virtual Status get_range_for(int64_t desiredOffset, io::PrefetchRange&
result_range) = 0;
+ virtual size_t get_max_range_size() const = 0;
+};
+
+class LinearProbeRangeFinder : public RangeFinder {
+public:
+ LinearProbeRangeFinder(std::vector<io::PrefetchRange>&& ranges) :
_ranges(std::move(ranges)) {}
+
+ Status get_range_for(int64_t desiredOffset, io::PrefetchRange&
result_range) override;
Review Comment:
`desired_offset `
##########
be/src/io/fs/buffered_reader.h:
##########
@@ -53,6 +53,121 @@ struct PrefetchRange {
: start_offset(start_offset), end_offset(end_offset) {}
PrefetchRange() : start_offset(0), end_offset(0) {}
+
+ PrefetchRange span(const PrefetchRange& other) const {
+ return {std::min(start_offset, other.end_offset),
std::max(start_offset, other.end_offset)};
+ }
+ PrefetchRange seq_span(const PrefetchRange& other) const {
+ return {start_offset, other.end_offset};
+ }
+
+ //Ranges needs to be sorted.
+ static std::vector<PrefetchRange> mergeAdjacentSeqRanges(
+ const std::vector<PrefetchRange>& seq_ranges, int64_t
max_merge_distance_bytes,
+ int64_t max_read_size_bytes) {
+ if (seq_ranges.empty()) {
+ return {};
+ }
+ // Merge overlapping ranges
+ std::vector<PrefetchRange> result;
+ PrefetchRange last = seq_ranges.front();
+ for (size_t i = 1; i < seq_ranges.size(); ++i) {
+ PrefetchRange current = seq_ranges[i];
+ PrefetchRange merged = last.seq_span(current);
+ if (merged.end_offset <= max_read_size_bytes + merged.start_offset
&&
+ last.end_offset + max_merge_distance_bytes >=
current.start_offset) {
+ last = merged;
+ } else {
+ result.push_back(last);
+ last = current;
+ }
+ }
+ result.push_back(last);
+ return result;
+ }
+};
+
+class RangeFinder {
+public:
+ virtual ~RangeFinder() = default;
+ virtual Status get_range_for(int64_t desiredOffset, io::PrefetchRange&
result_range) = 0;
Review Comment:
`desired_offset `
##########
be/src/io/fs/buffered_reader.h:
##########
@@ -53,6 +53,121 @@ struct PrefetchRange {
: start_offset(start_offset), end_offset(end_offset) {}
PrefetchRange() : start_offset(0), end_offset(0) {}
+
+ PrefetchRange span(const PrefetchRange& other) const {
+ return {std::min(start_offset, other.end_offset),
std::max(start_offset, other.end_offset)};
+ }
+ PrefetchRange seq_span(const PrefetchRange& other) const {
+ return {start_offset, other.end_offset};
+ }
+
+ //Ranges needs to be sorted.
+ static std::vector<PrefetchRange> mergeAdjacentSeqRanges(
Review Comment:
`merge_adjacent_seq_ranges()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
