gavinchou commented on code in PR #43220:
URL: https://github.com/apache/doris/pull/43220#discussion_r1827654667
##########
be/src/io/cache/fs_file_cache_storage.cpp:
##########
@@ -270,6 +276,18 @@ std::string
FSFileCacheStorage::get_path_in_local_cache_old_ttl_format(const std
return Path(dir) / (std::to_string(offset) +
BlockFileCache::cache_type_to_string(type));
}
+std::vector<std::string>
FSFileCacheStorage::get_path_in_local_cache_all_candidates(
+ const std::string& dir, size_t offset) {
+ std::vector<std::string> candidates;
+ std::string base = get_path_in_local_cache(dir, offset,
FileCacheType::NORMAL);
+ candidates.push_back(base);
+ candidates.push_back(base + "_idx");
+ candidates.push_back(base + "_ttl");
+ candidates.push_back(base + "_disposable");
+ candidates.push_back(base + "_tmp");
Review Comment:
_tmp cannot be a candidate, it may be not fully downloaded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
