gavinchou commented on code in PR #43220:
URL: https://github.com/apache/doris/pull/43220#discussion_r1827943721
##########
be/src/io/cache/fs_file_cache_storage.h:
##########
@@ -75,6 +75,9 @@ class FSFileCacheStorage : public FileCacheStorage {
FileCacheType
type,
bool is_tmp =
false);
+ [[nodiscard]] std::vector<std::string>
get_path_in_local_cache_all_candidates(
Review Comment:
function get_path_in_local_cache and get_path_in_local_cache_all_candidates
can be hidden in .cpp file only.
no need to expose them as member functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
