HappenLee commented on code in PR #42888:
URL: https://github.com/apache/doris/pull/42888#discussion_r1830692006
##########
be/src/vec/data_types/serde/data_type_datev2_serde.cpp:
##########
@@ -81,18 +82,18 @@ Status
DataTypeDateV2SerDe::deserialize_one_cell_from_json(IColumn& column, Slic
}
void DataTypeDateV2SerDe::write_column_to_arrow(const IColumn& column, const
NullMap* null_map,
- arrow::ArrayBuilder*
array_builder, int start,
- int end, const
cctz::time_zone& ctz) const {
+ arrow::ArrayBuilder*
array_builder, int64_t start,
+ int64_t end, const
cctz::time_zone& ctz) const {
const auto& col_data = static_cast<const
ColumnVector<UInt32>&>(column).get_data();
auto& date32_builder = assert_cast<arrow::Date32Builder&>(*array_builder);
for (size_t i = start; i < end; ++i) {
- int32_t daynr = binary_cast<UInt32,
DateV2Value<DateV2ValueType>>(col_data[i]).daynr() -
- date_threshold;
+ auto daynr = binary_cast<UInt32,
DateV2Value<DateV2ValueType>>(col_data[i]).daynr() -
+ date_threshold;
if (null_map && (*null_map)[i]) {
checkArrowStatus(date32_builder.AppendNull(), column.get_name(),
array_builder->type()->name());
} else {
- checkArrowStatus(date32_builder.Append(daynr), column.get_name(),
+ checkArrowStatus(date32_builder.Append(cast_set<int>(daynr)),
column.get_name(),
Review Comment:
here is a for loop need check every value ?
- [ ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
