HappenLee commented on code in PR #42888:
URL: https://github.com/apache/doris/pull/42888#discussion_r1830711165
##########
be/src/vec/data_types/serde/data_type_number_serde.h:
##########
@@ -121,14 +122,14 @@ Status
DataTypeNumberSerDe<T>::read_column_from_pb(IColumn& column, const PValue
column.resize(old_column_size + arg.uint32_value_size());
auto& data = assert_cast<ColumnType&>(column).get_data();
for (int i = 0; i < arg.uint32_value_size(); ++i) {
- data[old_column_size + i] = arg.uint32_value(i);
+ data[old_column_size + i] = cast_set<T,
uint32_t>(arg.uint32_value(i));
Review Comment:
for loop should not do the check? and should not check in T is UINT32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
