github-actions[bot] commented on code in PR #44454:
URL: https://github.com/apache/doris/pull/44454#discussion_r1853841662
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -684,8 +685,8 @@ char* write_four_digits_to_string(int number, char* dst) {
return dst + 4;
}
Review Comment:
warning: function 'to_format_string_conservative' has cognitive complexity
of 60 (threshold 50) [readability-function-cognitive-complexity]
```cpp
bool VecDateTimeValue::to_format_string_conservative(const char* format,
size_t len, char* to,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/runtime/vdatetime_value.cpp:688:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (check_range(_year, _month, _day, _hour, _minute, _second, _type)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:699:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
while (ptr < end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:700:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (to - begin + SAFE_FORMAT_STRING_MARGIN > max_valid_length)
[[unlikely]] {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:703:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (*ptr != '%' || (ptr + 1) == end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:703:** +1
```cpp
if (*ptr != '%' || (ptr + 1) == end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:709:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
switch (ch = *ptr++) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:760:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_type == TIME_TIME || (_year == 0 && _month == 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:760:** +1
```cpp
if (_type == TIME_TIME || (_year == 0 && _month == 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:760:** +1
```cpp
if (_type == TIME_TIME || (_year == 0 && _month == 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:767:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_month == 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:781:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_day >= 10 && _day <= 19) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:781:** +1
```cpp
if (_day >= 10 && _day <= 19) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:783:** +1, nesting level increased
to 3
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:784:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
switch (_day % 10) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:827:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_month == 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:834:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if ((_hour % 24) >= 12) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:836:** +1, nesting level increased
to 3
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:852:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if ((_hour % 24) >= 12) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:854:** +1, nesting level increased
to 3
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:874:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_type == TIME_TIME) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:884:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_type == TIME_TIME) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:894:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_type == TIME_TIME) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:904:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_type == TIME_TIME) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:913:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_type == TIME_TIME || (_month == 0 && _year == 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:913:** +1
```cpp
if (_type == TIME_TIME || (_month == 0 && _year == 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:913:** +1
```cpp
if (_type == TIME_TIME || (_month == 0 && _year == 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:926:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_type == TIME_TIME) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:939:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_type == TIME_TIME) {
^
```
</details>
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -1205,7 +1206,7 @@
// this method is exactly same as fromDateFormatStr() in DateLiteral.java in FE
// change this method should also change that.
Review Comment:
warning: function 'from_date_format_str' has cognitive complexity of 207
(threshold 50) [readability-function-cognitive-complexity]
```cpp
bool VecDateTimeValue::from_date_format_str(const char* format, int
format_len, const char* value,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/runtime/vdatetime_value.cpp:1208:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (value_len <= 0) [[unlikely]] {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1245:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
while (ptr < end && val < val_end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1245:** +1
```cpp
while (ptr < end && val < val_end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1247:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
while (val < val_end && check_space(*val)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1247:** +1
```cpp
while (val < val_end && check_space(*val)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1250:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (val >= val_end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1254:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (*ptr == '%' && ptr + 1 < end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1254:** +1
```cpp
if (*ptr == '%' && ptr + 1 < end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1258:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
switch (*ptr++) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1263:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1266:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
int_value += int_value >= 70 ? 1900 : 2000;
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1274:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1277:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (tmp - val <= 2) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1278:** +5, including nesting
penalty of 4, nesting level increased to 5
```cpp
int_value += int_value >= 70 ? 1900 : 2000;
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1288:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1297:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (int_value < 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1305:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (int_value < 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1315:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1324:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1341:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1351:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1362:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1373:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1380:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if ((val_end - val) < 2 || toupper(*(val + 1)) != 'M' ||
!hour_system_12) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1380:** +1
```cpp
if ((val_end - val) < 2 || toupper(*(val + 1)) != 'M' ||
!hour_system_12) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1383:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (toupper(*val) == 'P') {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1392:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (int_value < 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1401:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (int_value < 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1410:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1413:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (int_value >= 7) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1416:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (int_value == 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1425:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1436:** +1
```cpp
sunday_first = (*(ptr - 1) == 'U' || *(ptr - 1) == 'V');
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1438:** +1
```cpp
strict_week_number = (*(ptr - 1) == 'V' || *(ptr - 1) ==
'v');
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1440:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1444:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (week_num > 53 || (strict_week_number && week_num == 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1444:** +1
```cpp
if (week_num > 53 || (strict_week_number && week_num == 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1444:** +1
```cpp
if (week_num > 53 || (strict_week_number && week_num == 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1455:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1464:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!tmp_val.from_date_format_str("%I:%i:%S %p", 11, val,
val_end - val, &tmp)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1477:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!tmp_val.from_date_format_str("%H:%i:%S", 8, val,
val_end - val, &tmp)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1489:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
while (val < val_end && ispunct(*val)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1489:** +1
```cpp
while (val < val_end && ispunct(*val)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1494:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
while (val < val_end && isalpha(*val)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1494:** +1
```cpp
while (val < val_end && isalpha(*val)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1499:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
while (val < val_end && isdigit(*val)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1499:** +1
```cpp
while (val < val_end && isdigit(*val)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1504:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if ('%' != *val) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1512:** +1, nesting level increased
to 2
```cpp
} else if (!check_space(*ptr)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1513:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (*ptr != *val) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1518:** +1, nesting level increased
to 2
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1524:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
while (ptr < end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1525:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (*ptr == '%' && ptr + 1 < end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1525:** +1
```cpp
if (*ptr == '%' && ptr + 1 < end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1527:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
switch (*ptr++) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1545:** +1, nesting level increased
to 2
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1550:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (!part_used) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1554:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (hour_system_12) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1555:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (hour > 12 || hour < 1) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1555:** +1
```cpp
if (hour > 12 || hour < 1) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1560:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (sub_val_end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1565:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (part_used & DATE_PART) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1566:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (part_used & TIME_PART) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1568:** +1, nesting level increased
to 2
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1571:** +1, nesting level increased
to 1
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1578:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (yearday > 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1580:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (!get_date_from_daynr(days)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1585:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (week_num >= 0 && weekday > 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1585:** +1
```cpp
if (week_num >= 0 && weekday > 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1587:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if ((strict_week_number &&
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1588:** +1
```cpp
(strict_week_number_year < 0 || strict_week_number_year_type !=
sunday_first)) ||
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1587:** +1
```cpp
if ((strict_week_number &&
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1588:** +1
```cpp
(strict_week_number_year < 0 || strict_week_number_year_type !=
sunday_first)) ||
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1589:** +1
```cpp
(!strict_week_number && strict_week_number_year >= 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1593:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
doris::calc_daynr(strict_week_number ?
strict_week_number_year : year, 1, 1);
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1597:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (sunday_first) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1598:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
days += ((weekday_b == 0) ? 0 : 7) - weekday_b + (week_num - 1)
* 7 + weekday % 7;
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1599:** +1, nesting level increased
to 2
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1600:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
days += ((weekday_b <= 3) ? 0 : 7) - weekday_b + (week_num - 1)
* 7 + weekday - 1;
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1602:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (!get_date_from_daynr(days)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1610:** +1
```cpp
bool already_set_date_part = yearday > 0 || (week_num >= 0 && weekday >
0);
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1610:** +1
```cpp
bool already_set_date_part = yearday > 0 || (week_num >= 0 && weekday >
0);
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1611:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (already_set_date_part && already_set_time_part) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1611:** +1
```cpp
if (already_set_date_part && already_set_time_part) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1615:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (!(part_used & ~NORMAL_DATE_PART)) { // Ymd part only
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1616:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (!(part_used & DAY_PART)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1618:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (!(part_used & MONTH_PART)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1624:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (already_set_date_part) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:1627:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (already_set_time_part) {
^
```
</details>
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -2255,7 +2256,7 @@
// change this method should also change that.
template <typename T>
Review Comment:
warning: function 'from_date_format_str' has cognitive complexity of 248
(threshold 50) [readability-function-cognitive-complexity]
```cpp
bool DateV2Value<T>::from_date_format_str(const char* format, int
format_len, const char* value,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/runtime/vdatetime_value.cpp:2258:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (value_len <= 0) [[unlikely]] {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2296:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
while (ptr < end && val < val_end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2296:** +1
```cpp
while (ptr < end && val < val_end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2298:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
while (val < val_end && check_space(*val)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2298:** +1
```cpp
while (val < val_end && check_space(*val)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2301:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (val >= val_end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2305:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (*ptr == '%' && ptr + 1 < end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2305:** +1
```cpp
if (*ptr == '%' && ptr + 1 < end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2309:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
switch (*ptr++) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2314:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2317:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
int_value += int_value >= 70 ? 1900 : 2000;
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2325:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2328:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (tmp - val <= 2) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2329:** +5, including nesting
penalty of 4, nesting level increased to 5
```cpp
int_value += int_value >= 70 ? 1900 : 2000;
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2339:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2348:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (int_value < 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2356:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (int_value < 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2366:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2375:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2392:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2402:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2413:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2424:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
while (tmp < val_end && isdigit(*tmp)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2424:** +1
```cpp
while (tmp < val_end && isdigit(*tmp)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2428:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (tmp - val > 6) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2430:** +5, including nesting
penalty of 4, nesting level increased to 5
```cpp
if (!str_to_int64(val, &tmp2, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2433:** +1, nesting level increased
to 4
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2434:** +5, including nesting
penalty of 4, nesting level increased to 5
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2438:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if constexpr (is_datetime) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2447:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if ((val_end - val) < 2 || toupper(*(val + 1)) != 'M' ||
!hour_system_12) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2447:** +1
```cpp
if ((val_end - val) < 2 || toupper(*(val + 1)) != 'M' ||
!hour_system_12) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2450:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (toupper(*val) == 'P') {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2459:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (int_value < 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2468:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (int_value < 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2477:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2480:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (int_value >= 7) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2483:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (int_value == 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2492:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2503:** +1
```cpp
sunday_first = (*(ptr - 1) == 'U' || *(ptr - 1) == 'V');
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2505:** +1
```cpp
strict_week_number = (*(ptr - 1) == 'V' || *(ptr - 1) ==
'v');
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2507:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2511:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (week_num > 53 || (strict_week_number && week_num == 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2511:** +1
```cpp
if (week_num > 53 || (strict_week_number && week_num == 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2511:** +1
```cpp
if (week_num > 53 || (strict_week_number && week_num == 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2522:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!str_to_int64(val, &tmp, &int_value)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2530:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if constexpr (is_datetime) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2532:** +5, including nesting
penalty of 4, nesting level increased to 5
```cpp
if (!tmp_val.from_date_format_str("%I:%i:%S %p", 11,
val, val_end - val,
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2543:** +1, nesting level increased
to 4
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2548:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if constexpr (is_datetime) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2550:** +5, including nesting
penalty of 4, nesting level increased to 5
```cpp
if (!tmp_val.from_date_format_str("%H:%i:%S", 8, val,
val_end - val, &tmp)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2560:** +1, nesting level increased
to 4
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2565:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
while (val < val_end && ispunct(*val)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2565:** +1
```cpp
while (val < val_end && ispunct(*val)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2570:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
while (val < val_end && isalpha(*val)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2570:** +1
```cpp
while (val < val_end && isalpha(*val)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2575:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
while (val < val_end && isdigit(*val)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2575:** +1
```cpp
while (val < val_end && isdigit(*val)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2580:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if ('%' != *val) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2588:** +1, nesting level increased
to 2
```cpp
} else if (!isspace(*ptr)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2589:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (*ptr != *val) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2594:** +1, nesting level increased
to 2
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2600:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
while (ptr < end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2601:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (*ptr == '%' && ptr + 1 < end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2601:** +1
```cpp
if (*ptr == '%' && ptr + 1 < end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2603:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
switch (*ptr++) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2621:** +1, nesting level increased
to 2
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2626:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (!part_used) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2630:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (hour_system_12) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2631:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (hour > 12 || hour < 1) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2631:** +1
```cpp
if (hour > 12 || hour < 1) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2636:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (sub_val_end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2641:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (part_used & FRAC_PART) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2642:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if constexpr (!is_datetime) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2645:** +1, nesting level increased
to 1
```cpp
} else if (part_used & TIME_PART) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2646:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if constexpr (!is_datetime) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2652:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (yearday > 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2654:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (!get_date_from_daynr(days)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2659:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (week_num >= 0 && weekday > 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2659:** +1
```cpp
if (week_num >= 0 && weekday > 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2661:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if ((strict_week_number &&
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2662:** +1
```cpp
(strict_week_number_year < 0 || strict_week_number_year_type !=
sunday_first)) ||
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2661:** +1
```cpp
if ((strict_week_number &&
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2662:** +1
```cpp
(strict_week_number_year < 0 || strict_week_number_year_type !=
sunday_first)) ||
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2663:** +1
```cpp
(!strict_week_number && strict_week_number_year >= 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2667:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
doris::calc_daynr(strict_week_number ?
strict_week_number_year : year, 1, 1);
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2671:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (sunday_first) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2672:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
days += ((weekday_b == 0) ? 0 : 7) - weekday_b + (week_num - 1)
* 7 + weekday % 7;
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2673:** +1, nesting level increased
to 2
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2674:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
days += ((weekday_b <= 3) ? 0 : 7) - weekday_b + (week_num - 1)
* 7 + weekday - 1;
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2676:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (!get_date_from_daynr(days)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2684:** +1
```cpp
bool already_set_date_part = yearday > 0 || (week_num >= 0 && weekday >
0);
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2684:** +1
```cpp
bool already_set_date_part = yearday > 0 || (week_num >= 0 && weekday >
0);
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2685:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (already_set_date_part && already_set_time_part) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2685:** +1
```cpp
if (already_set_date_part && already_set_time_part) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2688:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (already_set_date_part) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2689:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if constexpr (is_datetime) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2692:** +1, nesting level increased
to 2
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2698:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (!(part_used & ~NORMAL_DATE_PART)) { // Ymd part only
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2699:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (!(part_used & DAY_PART)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2701:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (!(part_used & MONTH_PART)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2707:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (already_set_time_part) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2708:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if constexpr (is_datetime) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2712:** +1, nesting level increased
to 2
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2716:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if constexpr (is_datetime) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2719:** +1, nesting level increased
to 1
```cpp
} else {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
