github-actions[bot] commented on code in PR #44454:
URL: https://github.com/apache/doris/pull/44454#discussion_r1855420312
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -3450,8 +3450,8 @@ void DateV2Value<T>::set_microsecond(uint64_t
microsecond) {
}
template <typename T>
-bool DateV2Value<T>::to_format_string_conservative(const char* format, int
len, char* to,
- int max_valid_length) const
{
+bool DateV2Value<T>::to_format_string_conservative(const char* format, size_t
len, char* to,
Review Comment:
warning: function 'to_format_string_conservative' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
bool DateV2Value<T>::to_format_string_conservative(const char* format,
size_t len, char* to,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/runtime/vdatetime_value.cpp:3452:** 256 lines including
whitespace and comments (threshold 80)
```cpp
bool DateV2Value<T>::to_format_string_conservative(const char* format,
size_t len, char* to,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
