yiguolei commented on code in PR #9890: URL: https://github.com/apache/incubator-doris/pull/9890#discussion_r885708230
########## be/src/olap/convert_rowset.h: ########## @@ -0,0 +1,48 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "olap/merger.h" +#include "olap/storage_engine.h" +#include "olap/tablet.h" + +namespace doris { +class DataDir; +class ConvertRowset { +public: + ConvertRowset(TabletSharedPtr tablet) : _tablet(tablet) {} + Status prepare_convert(); + Status do_convert(); + +private: + Status construct_output_rowset_writer(); Review Comment: construct_input 和output rowset 都没用了，里面都就1行代码，不要单独的函数了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
