yiguolei commented on code in PR #9890:
URL: https://github.com/apache/incubator-doris/pull/9890#discussion_r886317062


##########
be/src/olap/olap_server.cpp:
##########
@@ -304,6 +320,27 @@ void StorageEngine::_tablet_checkpoint_callback(const 
std::vector<DataDir*>& dat
     } while 
(!_stop_background_threads_latch.wait_for(std::chrono::seconds(interval)));
 }
 
+void StorageEngine::_alpha_rowset_scan_thread_callback() {
+    LOG(INFO) << "try to start alpha rowset scan thread!";
+
+    do {
+        std::vector<TabletSharedPtr> tablet_have_alpha_rowset;
+        
_tablet_manager->find_tablet_have_alpha_rowset(tablet_have_alpha_rowset);
+        for (int i = 0; i < tablet_have_alpha_rowset.size(); ++i) {

Review Comment:
   这里不要一下submit 这么多task,我们最多submit 线程数 * 2 个task;现在这个写法会重复submit 很多相同的tablet 
到队列里啊。
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to