xinyiZzz commented on code in PR #9803:
URL: https://github.com/apache/incubator-doris/pull/9803#discussion_r886308720
##########
be/src/vec/sink/vdata_stream_sender.cpp:
##########
@@ -138,13 +144,27 @@ Status VDataStreamSender::Channel::send_block(PBlock*
block, bool eos) {
_closure->ref();
_closure->cntl.set_timeout_ms(_brpc_timeout_ms);
- if (_brpc_request.has_block()) {
- request_block_transfer_attachment<PTransmitDataParams,
-
RefCountClosure<PTransmitDataResult>>(
+ if (_parent->_column_values_buffer_ptr != nullptr &&
_brpc_request.has_block() &&
+ !_brpc_request.block().has_column_values()) {
+ DCHECK(_parent->_column_values_buffer.size() != 0);
+ request_embed_attachment_contain_block<PTransmitDataParams,
+
RefCountClosure<PTransmitDataResult>>(
&_brpc_request, _parent->_column_values_buffer, _closure);
+ std::string brpc_url;
+ brpc_url =
Review Comment:
`brpc_url` and `_brpc_http_stub` are only used in rare cases where
tuple/block > 2G, and no initialization is required in most cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
