yangzhg commented on code in PR #9803:
URL: https://github.com/apache/incubator-doris/pull/9803#discussion_r888792101
##########
be/src/runtime/row_batch.cpp:
##########
@@ -300,17 +290,13 @@ Status RowBatch::serialize(PRowBatch* output_batch,
size_t* uncompressed_size,
// return compressed and uncompressed size
size_t pb_size = get_batch_size(*output_batch);
- if (allocated_buf == nullptr) {
- *uncompressed_size = pb_size - mutable_tuple_data->size() +
tuple_byte_size;
- *compressed_size = pb_size;
- if (pb_size > std::numeric_limits<int32_t>::max()) {
- // the protobuf has a hard limit of 2GB for serialized data.
- return Status::InternalError(fmt::format(
- "The rowbatch is large than 2GB({}), can not send by
Protobuf.", pb_size));
- }
- } else {
- *uncompressed_size = pb_size + tuple_byte_size;
- *compressed_size = pb_size + mutable_tuple_data->size();
+ *uncompressed_size = pb_size - mutable_tuple_data->size() +
tuple_byte_size;
+ *compressed_size = pb_size;
+ if (config::transfer_large_data_by_brpc == false &&
Review Comment:
```suggestion
if (!config::transfer_large_data_by_brpc &&
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
