xinyiZzz commented on code in PR #9803:
URL: https://github.com/apache/incubator-doris/pull/9803#discussion_r889762556
##########
be/src/service/internal_service.cpp:
##########
@@ -66,19 +66,53 @@ void
PInternalServiceImpl::transmit_data(google::protobuf::RpcController* cntl_b
PTransmitDataResult* response,
google::protobuf::Closure* done) {
SCOPED_SWITCH_BTHREAD();
- VLOG_ROW << "transmit data: fragment_instance_id=" <<
print_id(request->finst_id())
- << " node=" << request->node_id();
+ // TODO(zxy) delete in 1.2 version
brpc::Controller* cntl = static_cast<brpc::Controller*>(cntl_base);
attachment_transfer_request_row_batch<PTransmitDataParams>(request, cntl);
+
+ _transmit_data(cntl_base, request, response, done, Status::OK());
+}
+
+void
PInternalServiceImpl::transmit_data_by_http(google::protobuf::RpcController*
cntl_base,
+ const PEchoRequest* request,
+ PTransmitDataResult* response,
+ google::protobuf::Closure*
done) {
+ SCOPED_SWITCH_BTHREAD();
+ PTransmitDataParams* request_raw = new PTransmitDataParams();
+ brpc::Controller* cntl = static_cast<brpc::Controller*>(cntl_base);
+ Status st =
attachment_extract_request_contain_tuple<PTransmitDataParams>(request_raw,
cntl);
+ _transmit_data(cntl_base, request_raw, response, done, st);
+}
+
+void PInternalServiceImpl::_transmit_data(google::protobuf::RpcController*
cntl_base,
+ const PTransmitDataParams* request,
+ PTransmitDataResult* response,
+ google::protobuf::Closure* done,
Status extract_st) {
Review Comment:
fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
