eldenmoon commented on code in PR #45947:
URL: https://github.com/apache/doris/pull/45947#discussion_r1903932813
##########
be/src/vec/columns/column_object.cpp:
##########
@@ -1965,12 +2046,18 @@ Status ColumnObject::finalize(FinalizeMode mode) {
for (auto&& entry : subcolumns) {
if (selected_path.find(entry->path.get_path()) !=
selected_path.end()) {
new_subcolumns.add(entry->path, entry->data);
- } else {
+ } else if (none_null_value_sizes.find(entry->path.get_path()) !=
+ none_null_value_sizes.end()) {
VLOG_DEBUG << "pick " << entry->path.get_path() << " as sparse
column";
remaing_subcolumns.emplace(entry->path.get_path(),
entry->data);
}
}
- serialized_sparse_column->clear();
+
+#ifndef NDEBUG
Review Comment:
use ENABLE_CHECK_CONSISTENCY(this) instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
