eldenmoon commented on code in PR #45947:
URL: https://github.com/apache/doris/pull/45947#discussion_r1904013486
##########
be/src/vec/columns/column_object.cpp:
##########
@@ -1297,27 +1295,12 @@ void ColumnObject::add_nested_subcolumn(const
PathInData& key, const FieldInfo&
}
void ColumnObject::set_num_rows(size_t n) {
- // for (auto& entry : subcolumns) {
- // if (auto size = entry->data.size(); size < n) {
- // entry->data.insert_many_defaults(n - size);
- // } else if (size > n) {
- // CHECK(false) << entry->path.get_path() << " has more data";
- // }
- // }
- // if (auto size = serialized_sparse_column->size(); size < n) {
- // serialized_sparse_column->insert_many_defaults(n - size);
- // } else if (size > n) {
- // CHECK(false) << " sparse column has more data";
- // }
- // check
num_rows = n;
- // ENABLE_CHECK_CONSISTENCY(this);
}
bool ColumnObject::try_add_new_subcolumn(const PathInData& path) {
- bool no_root = subcolumns.get_root() == nullptr;
- if (no_root || path.empty()) {
- CHECK(false);
+ if (subcolumns.get_root() == nullptr || path.empty()) {
+ throw Exception(ErrorCode::INTERNAL_ERROR, "column object has no rooot
or path is empty");
Review Comment:
root not rooot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
