eldenmoon commented on code in PR #50027:
URL: https://github.com/apache/doris/pull/50027#discussion_r2049917155
##########
be/src/olap/rowset/segment_v2/variant_column_writer_impl.cpp:
##########
@@ -652,26 +698,59 @@ Status VariantSubcolumnWriter::finalize() {
ptr->finalize();
DCHECK(ptr->is_finalized());
-
- TabletColumn flush_column = vectorized::schema_util::get_column_by_type(
- ptr->get_root_type(), _tablet_column->name(),
- vectorized::schema_util::ExtraInfo {
- .unique_id = -1,
- .parent_unique_id = _tablet_column->parent_unique_id(),
- .path_info = *_tablet_column->path_info_ptr()});
- ColumnWriterOptions opts = _opts;
const auto& parent_column =
_opts.rowset_ctx->tablet_schema->column_by_uid(_tablet_column->parent_unique_id());
+
+ TabletColumn flush_column;
+ vectorized::schema_util::SubColumnInfo sub_column_info;
+ if (auto current_path = _tablet_column->path_info_ptr()->copy_pop_front();
+ vectorized::schema_util::generate_sub_column_info(
+ *_opts.rowset_ctx->tablet_schema,
_tablet_column->parent_unique_id(),
+ current_path.get_path(), &sub_column_info)) {
+ flush_column = sub_column_info.column;
+ if (sub_column_info.index) {
+ _index = std::make_unique<TabletIndex>(*sub_column_info.index);
+
_index->set_escaped_escaped_index_suffix_path(flush_column.path_info_ptr()->get_path());
Review Comment:
add constructor for suffix_path like TabletIndex(const std::string& sufffix)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
