eldenmoon commented on code in PR #50027:
URL: https://github.com/apache/doris/pull/50027#discussion_r2049969185
##########
be/src/vec/columns/column_object.cpp:
##########
@@ -1113,7 +1113,11 @@ bool ColumnObject::try_add_new_subcolumn(const
PathInData& path) {
if (subcolumns.get_root() == nullptr || path.empty()) {
throw Exception(ErrorCode::INTERNAL_ERROR, "column object has no root
or path is empty");
}
- if (!_max_subcolumns_count || subcolumns.size() < _max_subcolumns_count +
1) {
+ if (path.get_is_typed()) {
+ return add_sub_column(path, num_rows);
+ }
+ if (!_max_subcolumns_count ||
+ (subcolumns.size() - typed_path_count) < _max_subcolumns_count + 1) {
Review Comment:
是否有必要减去typed_path_count
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
