zclllyybb commented on code in PR #51270:
URL: https://github.com/apache/doris/pull/51270#discussion_r2123658836


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/types/TimeV2Type.java:
##########
@@ -27,7 +29,9 @@
  */
 public class TimeV2Type extends PrimitiveType implements RangeScalable {

Review Comment:
   I think TimeV2Type is more proper. when we use different branch or timepoint 
of codes, if changing to TimeType, maybe we will confuse between old V1 type 
and new V2 type. keeping version growth also acts like what we did for Decimal 
types



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to