zclllyybb commented on code in PR #51270:
URL: https://github.com/apache/doris/pull/51270#discussion_r2123806090
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/types/TimeV2Type.java:
##########
@@ -57,6 +64,28 @@ public boolean equals(Object o) {
return o instanceof TimeV2Type;
}
+ //TODO: implement this method by parsing the string and get the scale of it
+ public static TimeV2Type forTypeFromString(String s) {
+ return MAX;
Review Comment:
I've done this. but I dont think it will make `select time '11:12:13.123456'
= time '11:12:13.12'` return false. bacause:
```sql
mysql> select cast("2020-12-12 12:12:12.123" as datetime) = cast("2020-12-12
12:12:12.1234" as datetime);
+--------------------------------------------------------------------------------------------+
| cast("2020-12-12 12:12:12.123" as datetime) = cast("2020-12-12
12:12:12.1234" as datetime) |
+--------------------------------------------------------------------------------------------+
|
1 |
+--------------------------------------------------------------------------------------------+
```
for anytype without scale, we dont its length now but just use zero
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
