yiguolei commented on code in PR #11658:
URL: https://github.com/apache/doris/pull/11658#discussion_r943062723
##########
be/src/runtime/memory/mem_tracker_limiter.h:
##########
@@ -72,7 +72,7 @@ class MemTrackerLimiter final : public MemTracker {
if (PerfCounters::get_vm_rss() + bytes >= MemInfo::mem_limit()) {
return Status::MemoryLimitExceeded(
"{}: TryConsume failed, bytes={} process whole
consumption={} mem limit={}",
- _label, bytes, MemInfo::current_mem(),
MemInfo::mem_limit());
Review Comment:
Hi, currently memtracker only count virtual memory. And sometimes virtual
memory is 3 times larger than physical memory.
I think we should include both virtual memory and physical memory in this
error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
