xinyiZzz commented on code in PR #11658:
URL: https://github.com/apache/doris/pull/11658#discussion_r944034747


##########
be/src/runtime/memory/mem_tracker_limiter.h:
##########
@@ -72,7 +72,7 @@ class MemTrackerLimiter final : public MemTracker {
         if (PerfCounters::get_vm_rss() + bytes >= MemInfo::mem_limit()) {
             return Status::MemoryLimitExceeded(
                     "{}: TryConsume failed, bytes={} process whole 
consumption={}  mem limit={}",
-                    _label, bytes, MemInfo::current_mem(), 
MemInfo::mem_limit());

Review Comment:
   It was a bug to only print virtual memory before, because the use of 
physical memory to judge exceed is here.
   
   Now be process virtual memory can be much larger than physical memory, I am 
investigating this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to