gavinchou commented on code in PR #52523:
URL: https://github.com/apache/doris/pull/52523#discussion_r2182011762


##########
cloud/src/recycler/recycler.cpp:
##########
@@ -985,9 +1099,11 @@ int InstanceRecycler::recycle_indexes() {
         return 0;
     };
 
-    return scan_for_recycle_and_statistics(index_key0, index_key1, "indexes", 
metrics_context,
-                                           std::move(scan_and_statistics), 
std::move(recycle_func),
-                                           std::move(loop_done));
+    if (config::enable_recycler_metrics) {

Review Comment:
   conf enable_recycler_metrics naming should be more specific 
   e.g. `enable_recycler_stats_metrics`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to