gavinchou commented on code in PR #52523:
URL: https://github.com/apache/doris/pull/52523#discussion_r2182276599
##########
cloud/src/recycler/recycler_service.cpp:
##########
@@ -52,6 +58,215 @@
RecyclerServiceImpl::RecyclerServiceImpl(std::shared_ptr<TxnKv> txn_kv, Recycler
RecyclerServiceImpl::~RecyclerServiceImpl() = default;
+void RecyclerServiceImpl::statistics_recycle(
+ ::google::protobuf::RpcController* controller,
+ const ::doris::cloud::StatisticsRecycleRequest* request,
+ ::doris::cloud::StatisticsRecycleResponse* response,
::google::protobuf::Closure* done) {
+ auto* ctrl = static_cast<brpc::Controller*>(controller);
+ LOG(INFO) << "rpc from " << ctrl->remote_side() << " request=" <<
request->ShortDebugString();
+ brpc::ClosureGuard closure_guard(done);
+ MetaServiceCode code = MetaServiceCode::OK;
+ std::string msg;
+ DORIS_CLOUD_DEFER {
+ response->mutable_status()->set_code(code);
+ response->mutable_status()->set_msg(msg);
+ LOG(INFO) << (code == MetaServiceCode::OK ? "succ to " : "failed to ")
Review Comment:
stats and return more info like
time elapsed, kv scanned, tablet scanned and etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
